Add arguments sharing and isolation section in diagnostic-struct of rdg
#2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
…of rdg Signed-off-by: xizheyin <[email protected]>
xizheyin
force-pushed
the
argument-sharing-and-isolation
branch
from
e39436d to
3bac737
Compare
|
r? @oli-obk |
oli-obk
reviewed
Jun 27, 2025
oli-obk
reviewed
Jun 27, 2025
oli-obk
reviewed
Jun 27, 2025
oli-obk
reviewed
Jun 27, 2025
oli-obk
reviewed
Jun 27, 2025
oli-obk
reviewed
Jun 27, 2025
Signed-off-by: xizheyin <[email protected]>
|
Thanks, I push the changes in the new commit. |
|
Great thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explains rules for deriving diagnostic shareing arguments in rdg. cc rust-lang/rust#142724
And fix some nits.